Vadim Petrochenkov

Results 344 comments of Vadim Petrochenkov

> Thanks for discussing this. I'll wait for the next beta branch so #128122 is on stable for at least a cycle, then continue pushing this forward. @tgross35 Do you...

Waiting on author to analyze the regressions and fix CI. @rustbot author

I think this is a good opportunity to expand the design space (and documentation) of "various levels of exportendess" a bit, even if the resulting proposal for `export_visibility` specifically stays...

>What remains to be done: I'd also want to block the stabilization on landing https://github.com/rust-lang/rust/pull/138844 to avoid a stable rustdoc feature relying on externally observable hacks in rustc. The crater...

>Just one thing left for the cfg expansion missing: `#[cfg_attr(blabla, derive(Debug))]` Do you mean like in #138515? :)

Do C/C++ toolchains for mingw address the `#[repr(system)]` issue in any way? What do they do when they need to interoperate with msvc-style layouts?

This may be a bit vague, but running an arbitrary logic for conditions in patterns sort of goes against the idea of a "pattern". Pattern is a "leaf" element of...

r=me after the commit squash https://github.com/rust-lang/rust/pull/142069#issuecomment-2965687086 @rustbot author

There's an old issue about this (opened when the edition mechanism was introduced), and I recently wrote some update on the current state of affairs - https://github.com/rust-lang/rust/issues/50122#issuecomment-2186400934. Given that I...