Vadim Petrochenkov

Results 344 comments of Vadim Petrochenkov

This already fits into the existing `UNUSED_ATTRIBUTES` lint because `#[no_mangle]` is unused in this situation. I don't think every tiny possible niche issue needs a separate lint. @rfcbot concern unjustified-new-lint

Empty bound lists (and other lists) are accepted in other contexts as well, e.g. `fn f() { ... }`, so `trait Trait = /*nothing*/;` being accepted is more of a...

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-126571/retry-regressed-list.txt

@craterbot check p=1 crates=https://gist.githubusercontent.com/petrochenkov/d33e774c2065457db57d1dee3713f55a/raw/c43de2eb8109a15dce33173973a03ffc424e58b9/gistfile1.txt

>do you have opinions about which of these should be accepted? After migrating to the token model - everything that fits into both the expression and the pattern syntax as...

Still waiting on the author to answer. @nnethercote Do you plan to return to this?