Peter Todd

Did you try the unit tests? Just tried them and both python2 and python3 unit tests seem to be failing with this change. You can run them with the following...

Adding this for my own notes when I get some time to look into this: https://b10c.me/blog/006-evolution-of-the-bitcoin-signature-length/

I wonder if you guys have a different `bitcoin` module installed in your PYTHON_PATH?

Yeah, writing py3-only code is fine now. Is there anything else you'd do if this pull-req was py3-only?

Do you have any code that uses this that I can look at?

Hey, sorry I haven't merged this yet, travelling. :( Mind writing up a thing in the README explaining the idea behind params, like as a code best practices? I wanted...

We can't change the name `testnet` to `testnet3`, as that would break backwards compatibility unnecessarily.

Ah sorry, no I am incorrect. My concern was that changing 'testnet' to 'testnet3' would break `SelectParams()`. But that function has it's own set of names. That said, I think...

On Mon, Nov 06, 2023 at 05:26:09PM -0800, farahats9 wrote: > Any idea when this will be implemented? Probably never. What I should be doing is removing VerifyScript as there's...

I think the minikey functionality should be in a different file than base58. Also, it doesn't make sense to decode minikeys to base58 - minikey decoding should be done to/from...