python-bitcoinlib icon indicating copy to clipboard operation
python-bitcoinlib copied to clipboard

Published 20 hours ago • verified publisher icon petertodd

Refactor and some test for RPC

Open Titan-C opened this issue 4 years ago • 3 comments
trafficstars

I couldn't connect to the testnet by cookie. First commit fixes it. Then I tried to refactor a bit to flatten the structure of the config parser. Added some tests.

Titan-C avatar Jan 02 '21 23:01 Titan-C

We can't change the name testnet to testnet3, as that would break backwards compatibility unnecessarily.

petertodd avatar Jun 02 '23 15:06 petertodd

Excuse my ignorance, but where does testnet work? Should I create a new class with testnet3?

Titan-C avatar Jun 03 '23 17:06 Titan-C

Ah sorry, no I am incorrect. My concern was that changing 'testnet' to 'testnet3' would break SelectParams(). But that function has it's own set of names. That said, I think I'll merge https://github.com/petertodd/python-bitcoinlib/pull/234 first and do a minor release with that fix first.

petertodd avatar Jun 03 '23 18:06 petertodd