Peter Todd comments

Results 309 comments of


                                            Peter Todd

trafficstars

Decode minikeys (like Casascius coin ones)

Ah right, I should have realized a minikey is obviously a one-way transformation. Note that you also may consider just making this functionality a separate Python library - it might...

Convert to libsecp256k1

That'd also make it easy to add HD key derivation operations too. One disadvantage though is it's a dependency, and unless I'm mistaken secp256k1 isn't available on Windows. A reasonable...

do you have plan to support bip32

Pull-reqs welcome!

do you have plan to support bip32

@shalakhin It does not.

Error: File "/usr/lib/python3.4/json/decoder.py", line 361, in raw_decode raise ValueError(errmsg("Expecting value", s, err.value)) from None

Weird. What version of Bitcoin Core are you running?

Error: File "/usr/lib/python3.4/json/decoder.py", line 361, in raw_decode raise ValueError(errmsg("Expecting value", s, err.value)) from None

Huh, sorry, I can't seem to reproduce that here. What's your bitcoin.conf? That's a non-standard service port.

Bignum handling is dodgy

@posita The BigNum handling doesn't need an external dependency, especially how that Bitcoin Core doesn't actually use it. What needs to be done is just a review/cleanup of the code...

AssertionError when calculating SignatureHash

Fixed now that #187 is merged?

AssertionError when calculating SignatureHash

@dgpv Wait, what do you mean by your code snippet above?

AssertionError when calculating SignatureHash

@dgpv Ah! Well, if you figure out a fix, pull-req accepted, and I'll try to merge it in a more reasonable amount of time than your other (much appreciated!) segwit...