Peter Todd

Results 316 comments of Peter Todd

Hmm, I think for something like this we'll need a fairly detailed writeup, ideally with specific quotes, tweets, etc. It's a good first start though, so thanks! Interested to see...

It'd be good to get additional examples of how Lightning has not been portrayed as a panacea, e.g. from the original whitepaper, etc. to make this more clear.

In my discussions with miners about Libre Relay, a key thing they've asked for is good unit tests. So any change like this needs to be combined with whatever changes...

I think it'd be more useful to carefully analyze whether or not the stack element sizes pose a DoS attack risk. If they don't, we can just remove the limit....

Two issues with this: 1. The `MAX_DATACARRIER_OUTPUTS = 100` limit is much too low for the spirit of libre relay. The default limit should be sufficiently high to be impossible...

> Pushed an update, addressing the 2 concerns. Thing is, you haven't really addressed the second concern. Every bit of code added to Libre Relay is code that needs to...

> Going further, why not removing max OP_RETURN check completely rather than commenting out ? IIRC I wanted it to be clear what was there for reference for future rebases....

I'd say do whatever is best for your PR. We can fix conflicts later. On August 12, 2020 5:41:40 PM EDT, Sachin Meier wrote: >I am currently working on a...

Note that you're adding another dependency here, the retrying library. Can this be rewritten to not have that dependency? Also, are we 100% sure that this won't cause us to...

Awesome, thanks! I've really busy for the rest of this week, but I should get a chance to look at this next week.