Peter Schutt

Results 174 comments of Peter Schutt

Hey, I'm not a maintainer but only came across your question today, I know it's a bit of a late response! There isn't any prose section of the docs that...

By explicitly setting the `data_key` and `attribute` args to the `_password` I was able to get all of your tests to pass: ```py from marshmallow_sqlalchemy import SQLAlchemyAutoSchema, auto_field from sqlalchemy...

Hey, can you provide a minimal example of this that I can run to verify? I cannot see how the library would add an expunged instance back into the session...

Hi Mike, Sorry it's taken me a little while to pick this up. Following on from above, I notice that both of those doc sections also mention that Precision is...

If you are using an ORM (sqlalchemy/django) then the wtforms `QuerySelectField` from the relevant wtforms extension have an `allow_blank` argument, where if `True` adds a blank field automatically. E.g.: ```python...

`cast()` accepts the type as the first argument and the value as second arg, eg, `cast(BigInteger, key)`.

Oh my bad! Totally read it as typing cast

Maybe we should try to emulate the techempower benchmarking?

It's this test in `test_picologging.py`: ```python def test_logger_startup(caplog: "LogCaptureFixture") -> None: with TestClient( app=Starlite( route_handlers=[], on_startup=[ LoggingConfig( handlers={ "console": { "class": "picologging.StreamHandler", "level": "DEBUG", "formatter": "standard", }, "queue_listener": { "class":...

Also @cofin, there is this stuff defined in module scope in `test_picologging.py`: https://github.com/starlite-api/starlite/blob/c9387f8c24b0e66fadbceecf05f3611b76f6b7bf/tests/logging_config/test_picologging.py#L106-L120 If I delete it, all the tests still pass, does it need to be there? If so,...