Peter Schutt
Peter Schutt
Other things TODO: - [x] update the contributing docs with instructions for reference docs as part of contributions - [x] change instructions in `CONTRIBUTING.md` for serving docs locally - the...
This is wrong: https://github.com/starlite-api/starlite/blob/db1eab98c50c1ed9fa176e7e06c3b34ddee68197/starlite/app.py#L123-L125
Documented in wrong location: https://github.com/starlite-api/starlite/blob/db1eab98c50c1ed9fa176e7e06c3b34ddee68197/docs/reference/enums.md?plain=1#L15-L19 It's defined in `config.py`
Any thoughts on how you'd like this implemented @Goldziher
> So, there is a problem with defining concrete attributes on protocols - pydantic doesn't play nice with this. OK cool, Also there is the nature of a protocol being...
> So, as a container I'd try to do something like this probably: > > ```python > from pydantic import validate_arguments > from starlite.params import Parameter > from starlette.middleware.base import...
Why would we want validated access to parameters inside a middleware? It just seems natural if we are bookkeeping all the types anyway that we could offer an interface to...
OK say that I want build middleware that logs some info drawn from a header and it should be an error if a client is missing that header value (I...
Yes, a way that could provide type info for the middleware required params for documenting (I think that was what the original convo in discord was about) and so just...
We were specifically talking about logging with gunicorn workers - great to have a full example, but just want to make sure that the logging topic doesn't get lost.