Peter Schutt

Results 174 comments of Peter Schutt

> What's the latest on this @RobertRosca @peterschutt ? Nothing further from me since my last comments.

One difference between the two implementation is that the router version doesn't have access to the favicon or style inside the 404 error handler.. I don't know how "breaking" to...

> > should we export the plugins into contrib and document them in that namespace? > > > > Maybe? Moving `litestar/openapi/plugins.py` into `litestar/plugins/openapi.py` might adhere to principle of least...

Hey @dybi - sorry about the delayed response here. Did you read this: https://github.com/orgs/litestar-org/discussions/1789#discussioncomment-6110017 I think an appropriately used application factory pattern is what you need.

OK thanks for persisting with us, I have reproduced. This is a recurring theme with our dependencies. The value that is returned from the dependency provider is validated according to...

Agree - it would be great to be more flexible in this respect!

> @peterschutt this seems to be ready? Yeh close - no tests. I have some related changes to PR, however I'm AFK for the weekend.

If an argument to `Annotated` is not hashable, e.g., `Annotated[int, {"set"}]`, then `msgspec.inspect.type_info()` throws a `TypeError`. I created https://github.com/jcrist/msgspec/issues/565 for that, however, for the tests to pass we'd either need...

> Is that `unsafe_hash` needed for msgpsec? Yep. Msgspec passes the type into `dict.get()` which calls `_AnnotatedAlias.__hash__()` which in turn passes a tuple of the instance and its metadata to...