Peter Metz
Peter Metz
@outSH Agreed, 100%. It would be great to have a single custom-check script responsible for the bulk of the package.json validations that are easy to describe declaratively with a Joi...
@AzaharaC @jordigiam @kikoncuo https://github.com/petermetz/cactus/blob/b05e7eb0854111fb945448ab1b207570db4e539e/tools/render-resources.js#L58 ```typescript let outFilePath; if (!path.isAbsolute(outputDir)) { outFilePath = path.join(process.cwd(), outputDir, `${entry}.json`); } else { outFilePath = path.join(outputDir, entry, ".json"); } ``` Just FYI/dumping thoughts regarding the...
@musicboy0322 Sorry for the slow response! I assigned it just now!
@ashnashahgrover Are you still working on this? If not, we can close it down and pick it back up later. I'm trying to keep the PR queue fresh.
Suggested edit: ```diff diff --git a/packages/cactus-plugin-ledger-connector-daml/src/test/typescript/integration/daml-get-transaction.test.ts b/packages/cactus-plugin-ledger-connector-daml/src/test/typescript/integration/daml-get-transaction.test.ts index 490c5ff23..b4d3fb42d 100644 --- a/packages/cactus-plugin-ledger-connector-daml/src/test/typescript/integration/daml-get-transaction.test.ts +++ b/packages/cactus-plugin-ledger-connector-daml/src/test/typescript/integration/daml-get-transaction.test.ts @@ -6,11 +6,10 @@ import { LoggerProvider, Logger, } from "@hyperledger/cactus-common"; + +import { DAML_TEST_LEDGER_DEFAULT_OPTIONS }...
@raynatopedrajeta See my suggestions above and also this: https://github.com/hyperledger/cacti/pkgs/container/cacti-daml-all-in-one
@raynatopedrajeta Got it thank you! I did create and upload the image (link in my previous comment). The suggested edits also contain the source code change that updates the code...
One step closer to making this happen. ```sh deno cache --allow-scripts=npm:secp256k1 npm:protobufjs ./examples/cacti-example-deno-1/ ``` ```sh peter@zend:~/a/cacti-upstream$ curl -fsSL https://deno.land/install.sh | sh ######################################################################## 100.0% Archive: /home/peter/.deno/bin/deno.zip inflating: /home/peter/.deno/bin/deno Deno was installed...
```sh $ docker run --privileged --rm tonistiigi/binfmt --install all Unable to find image 'tonistiigi/binfmt:latest' locally latest: Pulling from tonistiigi/binfmt 8d4d64c318a5: Pull complete e9c608ddc3cb: Pull complete Digest: sha256:66e11bea77a5ea9d6f0fe79b57cd2b189b5d15b93a2bdb925be22949232e4e55 Status: Downloaded newer...
@suumona Are you planning on working on this by any chance? If yes then I can assign it to you.