Peter Bourgon

Results 363 comments of Peter Bourgon

Config files aren't tiny databases that can be mutated over time, they're meant to be sources of truth that are read-only for the consumers that rely on them. This would...

I think the disconnect here is about the relationship between a config file and the program which reads it. Config files are typically _input to_ or _dependencies of_ programs, basically...

Yeah! It makes a lot of sense for kubectl to own and manipulate its config file. That's because kubectl is a CLI tool, typically run interactively by users on workstations,...

> The entire client config file . . . What config file(s) are we talking about? The OP makes me believe it's the node's app.toml and config.toml.

> One feature that I'd like to add too, is a `config update` command that . . . regenerate[s] the config files . . . [and fills] in new fields...

> (discovery of new flags) `program -h` describes the configuration surface area of a program without requiring the user to look at source code. > The fix was to have...

@iramiller > it is great that Ansible/Chef/K8s/etc and configuration from official record are useful tool for managing a production environment. **It is very curious that you do not mention where...

[This code path](https://github.com/cosmos/iavl/blame/f4499a9daed0a190a4df8d55950fb5d51c835bc9/immutable_tree.go#L25-L28) returns a pointer to an ImmutableTree with an ndb field that is nil, which is not valid. There are several other code paths in [mutable_tree.go](https://github.com/cosmos/iavl/blob/f4499a9daed0a190a4df8d55950fb5d51c835bc9/mutable_tree.go) which manually...

Can you please provide unit tests that ensure the change is backwards compatible across some reasonable corpus of input data, and some benchmarks that demonstrate the change provides a meaningful...

Any suggestion? ```shell $ go test -v -run=xxx -bench='(BenchmarkQueryBalance|BenchmarkQueryAllBalances|BenchmarkQueryVotes|BenchmarkQuerySigningInfos|BenchmarkQueryValidatorDelegations)' . goos: darwin goarch: arm64 pkg: cosmossdk.io/simapp BenchmarkQueryBalance benchs_test.go:47: wrong balance 0 742318 --- FAIL: BenchmarkQueryBalance BenchmarkQueryAllBalances benchs_test.go:67: wrong balance 0...