Peter Bourgon
Peter Bourgon
Nice. This is IMO a candidate for #10 rather than #9; I have no specific interest in Jepsen itself, merely a tool of its capability.
GetAllSlice too!
Are writes not atomic if you set TempDir to the same physical disk as the diskv path?
Unless I fundamentally misunderstand the semantics of modern filesystems — which is possible! — an open os.File should be a snapshot of its contents when opened, and should not change...
Ah, yes, I see, it's a consequence of the TempDir decisionmaking and the mode flags we pass. Solution here is to enforce a default TempDir in the diskv path if...
Would it be smarter to check both d.CacheSizeMax and fi.Size in readWithRLock, and only create and use the siphon if the file size could conceivably fit in the cache?
Do you use diskv in situations where there are values with such disparate sizes, and you hope to cache the smaller ones but not cache the larger ones?
Hmm, I don't think this PR does what you think it does — that `panic` indicates a reasonably serious error, I think. Can you say a bit more what you're...
Yes, I can't see how that would manifest. Confusing. Would you be willing to try and reproduce with a bit more info added to the panic? ```patch - panic(fmt.Sprintf("%d bytes...