Peter Bourgon
Peter Bourgon
Thanks for the notification! For anyone reading this later, that dependency is not really for `ff` but just `ffyaml` -- which is just an example of one possible YAML config...
I'm happy to accept a change that removes the call to UTC in Timestamp, can you add a benchmark that demonstrates the benefit? But I'm not sure it's common knowledge...
> whether Now() would (incorrectly) be somehow affected by the system time zone (which it isn't). To me, fixing this by removing that part of the comment is the most...
I've misunderstood something here, let me revert.
Please look at this PR from the perspective of a future maintainer. Help them understand how this works, and why it's better than the previous approach, with documentation.
Of course, but when this code is merged, it becomes my responsibility, so I need to understand it, even if you don't :)
```go // We use -1 (all bits are set to 1) as sentinel value for invalid indexes. // The reason for using -1 is that, even when cast, it does...
Ha, that's pretty good. I get even slightly better results than you did: ``` name old time/op new time/op delta Marshal/Text-11 9.94ns ± 0% 7.14ns ± 4% -28.19% (p=0.002 n=6+6)...
Same as #116, please help future maintainers (and me!) understand how this works, and why it's better that the previous implementation, with some form of documentation.
Is the benefit purely or mostly derived from the additional entropy of the initial seed? Twice as slow, even at the level of single-digit nanoseconds, is actually potentially meaningful for...