Peter Bourgon comments

Repositories
Issues
Comments

Results 363 comments of


                                            Peter Bourgon

Dependency gopkg.in/yaml.v2 is now unmaintained

Thanks for the notification! For anyone reading this later, that dependency is not really for `ff` but just `ffyaml` -- which is just an example of one possible YAML config...

refactor(timestamp): remove redundant `.UTC()` call and mentions

I'm happy to accept a change that removes the call to UTC in Timestamp, can you add a benchmark that demonstrates the benefit? But I'm not sure it's common knowledge...

refactor(timestamp): remove redundant `.UTC()` call and mentions

> whether Now() would (incorrectly) be somehow affected by the system time zone (which it isn't). To me, fixing this by removing that part of the comment is the most...