Peter Bourgon
Peter Bourgon
I agree with @tsenart. I'm coming at it from a slightly different angle. This PR would change [the Result type](https://pkg.go.dev/github.com/tsenart/vegeta/[email protected]/lib#Result) to no longer be an _HTTP_ result, but actually an...
The Result type has always represented a direct/raw HTTP response. This PR would allow the Result type to represent either an HTTP response or a GQL response, based on a...
> Strictly speaking, the Result type, is already a HitResult, which happens to contain fields from the raw HTTP response. Vegeta is — or, until this PR, _was_ — an...
I also have this problem.
Missing tests.
> it would be the responsibility of each consumer to verify the context isn't canceled This is already the case -- consumers must always inspect the received context, and return...
These proposals aren't intended to be perfect or exhaustive solutions to the complex problems they address — they're intended to be (substantial) improvements to the status quo. It is of...
> I think some signal from the module author should be required to show a notice The problem we're trying to solve is package consumers who intend to take the...
> The problem is that they look like warnings and will create more and more noise as a project gets older. We propose only a single line of output per...
> Over time, as new major versions of your dependencies are released, more notices are printed. No, I don't think so. At least, the proposal doesn't intend so. Notices are...