Peter Bourgon

Results 350 comments of Peter Bourgon

Oops, I saw the issue after I saw the PR. To echo my response from there: this seems easily solved by using fully-qualified ShortUsage strings for each subcommand, e.g. ```go...

I understand the points you're making, but I'm having trouble evaluating them. Can you give me some kind of concrete example? Various `-h` outputs from a [theoretical] command where this...

Just a note that I'm still processing this. Thanks for the feedback.

Sure. Just make sure to update tests :)

Now that I think on it a bit, this specific case devolves to a more general case: what I could really use is ``` func (t *Tree) IterAscendFrom(start Item)

Bryan takes a fairly esoteric view on what are pretty common synchronization primitives. +1 to a sync.Cond example, but be careful! :)

I agree with @eliben — named returns should only be used when necessary. In your example case, there's no benefit to using them. Also, the naked `return` should almost never...

Also, maybe I'm daft, but does `Mux.routes` need to be `*[]route` or can it just be `[]route`? _edit_: and, actually, I bet you'd be better served by `[]*route` — fewer...

Ah, I see! The Handle/HandleFunc methods are capturing the state of the outer Mux — most importantly, the middlewares that have been defined in it so far — and folding...

@alexedwards Nice!