Andrea Perrotta
Andrea Perrotta
please abort (trying to recover resources for the tests of more urgent PRs)
> @perrotta There were several serious bugs in the code which is corrected here. So if any external file is used in the testing, they are needed to be recreated...
> @perrotta My point was that if the additional files which are needed in the test be created with the same PR Please create those files and add them as...
@AWildridge I suspect that already existing configs which do not include the new "RequiredOutgoingStatus" parameter will break. Can I suggest you to add a fillDescriptions method to properly initialize the...
Run3-sim129 Use token rather than label for accessing collections in FastSimulation/ForwardDetectors
@bsunanda @civanch the suggestion https://github.com/cms-sw/cmssw/pull/39666#pullrequestreview-1135371310 of mine was not included in the last update. Ok, not a big issue, we can live as such, However, since there is a local...
Run3-sim129 Use token rather than label for accessing collections in FastSimulation/ForwardDetectors
> @perrotta It gets printed - I believe that is good enough It doesn't get printed, because the LogVerbatim is commented out. My suggestion was indeed to comment both lines...
Run3-sim129 Use token rather than label for accessing collections in FastSimulation/ForwardDetectors
> @perrotta the log verbatim is not commented out. Please take a look at the code Ah, ok @bsunanda : now I see that you already fixed it in a...
Run3-sim129 Use token rather than label for accessing collections in FastSimulation/ForwardDetectors
+1
backport of https://github.com/cms-sw/cmssw/pull/39487