cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[Backport] [GEM] Unpacker update for the vfat masking information [12_5_X]

Open yeckang opened this issue 3 years ago • 6 comments

PR description:

  • GEM Unpacker and data formats are updated to save the vfat masking information
  • Minor bugfix for the VFATStatus (Positional information)
  • The results of this update has approved in GEM DPG meeting (link)
  • Backport to CMSSW_12_5_X and CMSSW_12_4_X are needed.

PR validation:

  • The code format has applied with scram build code-format and tested with scram build code-checks.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

  • The original PR is #39487

yeckang avatar Sep 23 '22 10:09 yeckang

A new Pull Request was created by @yeckang (Yechan Kang) for CMSSW_12_5_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • DataFormats/GEMDigi (upgrade, simulation)
  • EventFilter/GEMRawToDigi (reconstruction)

@civanch, @clacaputo, @mandrenguyen, @emanueleusai, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @giovanni-mocellin, @jshlee, @rovere, @eyigitba, @Martin-Grunewald, @missirol, @watson-ij, @trtomei, @beaucero this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

  • Backported from #39487

cmsbuild avatar Sep 23 '22 10:09 cmsbuild

please test

emanueleusai avatar Sep 26 '22 22:09 emanueleusai

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0636a/27781/summary.html COMMIT: cb8d8d7f5c7c0579fe0eed2f75bc64fff53dcee1 CMSSW: CMSSW_12_5_X_2022-09-26-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39488/27781/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3699418
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Sep 27 '22 04:09 cmsbuild

+1

  • DQM code ok. Same considerations as in https://github.com/cms-sw/cmssw/pull/39489

emanueleusai avatar Sep 29 '22 17:09 emanueleusai

+1

mandrenguyen avatar Sep 30 '22 14:09 mandrenguyen

backport of https://github.com/cms-sw/cmssw/pull/39487

perrotta avatar Sep 30 '22 14:09 perrotta

@cmsbuild please test

Retrigger the test after 3 weeks.

srimanob avatar Oct 18 '22 15:10 srimanob

-1

Failed Tests: UnitTests Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0636a/28337/summary.html COMMIT: cb8d8d7f5c7c0579fe0eed2f75bc64fff53dcee1 CMSSW: CMSSW_12_5_X_2022-10-18-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39488/28337/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3697216
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697186
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 18 '22 18:10 cmsbuild

  • This PR is a verbatim backport of https://github.com/cms-sw/cmssw/pull/39487 as merged in the master
  • The unit test error that showed up in the last PR tests looks unrelated
  • At the ORP meeting of Oct 18 it was suggested to have this merged in 12_5 before cutting the release for the L1T Phase2 MC production

@cms-sw/simulation-l2 @cms-sw/upgrade-l2 do you have further concerns with it? Could you please review, and possibly sign if not?

perrotta avatar Oct 19 '22 08:10 perrotta

+Upgrade

Thanks @perrotta for the summary.

srimanob avatar Oct 19 '22 08:10 srimanob

+1

  • Unit test failures are unrelated, will force merge.

rappoccio avatar Oct 19 '22 13:10 rappoccio

@cms-sw/simulation-l2 this PR was merged by mistake bypassing your signature: sorry for that,

Since we plan to build 12_5_1 with it by tomorrow, could you please let us know if it is ok for you (and you can still sign it to show that), or if you have any concern about it (and in that case we can revert this one and build 12_5_1 for Phase2 L1T without it). Thank you!

perrotta avatar Oct 19 '22 14:10 perrotta

+1

sorry for the delay

civanch avatar Oct 19 '22 15:10 civanch

Thank you @civanch !

perrotta avatar Oct 19 '22 15:10 perrotta

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_6_X is complete.

cmsbuild avatar Oct 19 '22 15:10 cmsbuild