cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry

Open bsunanda opened this issue 3 years ago • 32 comments

PR description:

Try to address cassette shift abnormality for HGCal geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

bsunanda avatar Oct 05 '22 11:10 bsunanda

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32419

  • This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32419/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32419/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 05 '22 11:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32420

  • This PR adds an extra 80KB to repository

cmsbuild avatar Oct 05 '22 11:10 cmsbuild

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)
  • SimG4CMS/Calo (simulation)
  • Validation/HGCalValidation (dqm)

@civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. @youyingli, @vandreev11, @fabiocos, @lecriste, @sethzenz, @missirol, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @pfs, @thomreis, @hatakeyamak, @trtomei, @ebrondol, @beaucero, @slomeo, @simonepigazzini this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Oct 05 '22 11:10 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32422

  • This PR adds an extra 88KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32422/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32422/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 05 '22 11:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32423

  • This PR adds an extra 88KB to repository

cmsbuild avatar Oct 05 '22 11:10 cmsbuild

Pull request #39625 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild avatar Oct 05 '22 11:10 cmsbuild

@cmsbuild Please test

bsunanda avatar Oct 05 '22 11:10 bsunanda

-1

Failed Tests: Build HeaderConsistency Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8ded7/28020/summary.html COMMIT: 6646660b7fa12966032d5f79b19d27ea8d646f22 CMSSW: CMSSW_12_6_X_2022-10-05-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39625/28020/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/SimCalorimetry/HGCalSimAlgos/test/HFNoseNoiseMapAnalyzer.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/SimCalorimetry/HGCalSimAlgos/interface/HGCalSiNoiseMap.h:145,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/SimCalorimetry/HGCalSimAlgos/test/HFNoseNoiseMapAnalyzer.cc:18:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/SimCalorimetry/HGCalSimAlgos/interface/HGCalSiNoiseMap.icc: In instantiation of 'HGCalSiNoiseMap::SiCellOpCharacteristics HGCalSiNoiseMap::getSiCellOpCharacteristics(const T&, HGCalSiNoiseMap::GainRange_t, int) [with T = HGCSiliconDetId]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/SimCalorimetry/HGCalSimAlgos/interface/HGCalSiNoiseMap.h:147:16:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/SimCalorimetry/HGCalSimAlgos/interface/HGCalSiNoiseMap.icc:162:24: error: no matching function for call to 'HGCalDDDConstants::locateCell(int, int, int, int, int, bool, bool) const'
  162 |       ddd()->locateCell(cellId.layer(), cellId.waferU(), cellId.waferV(), cellId.cellU(), cellId.cellV(), true, true));
      |       ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/Geometry/CaloTopology/interface/HGCalTopology.h:7,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/Geometry/HGCalGeometry/interface/HGCalGeometry.h:24,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_6_X_2022-10-05-1100/src/SimCalorimetry/HGCalSimAlgos/test/HFNoseNoiseMapAnalyzer.cc:14:

cmsbuild avatar Oct 05 '22 12:10 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32430

  • This PR adds an extra 92KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32430/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32430/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Oct 05 '22 16:10 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39625/32433

  • This PR adds an extra 92KB to repository

cmsbuild avatar Oct 05 '22 16:10 cmsbuild

Pull request #39625 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

cmsbuild avatar Oct 05 '22 16:10 cmsbuild

@cmsbuild Please test

bsunanda avatar Oct 06 '22 01:10 bsunanda

please abort (trying to recover resources for the tests of more urgent PRs)

perrotta avatar Oct 06 '22 08:10 perrotta

please test

emanueleusai avatar Oct 07 '22 05:10 emanueleusai

-1

Failed Tests: RelVals RelVals-INPUT AddOn Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8ded7/28049/summary.html COMMIT: 002f6356539ce9b23b2aa967859c8b9c4ce9b561 CMSSW: CMSSW_12_6_X_2022-10-05-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39625/28049/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 06-Oct-2022 10:45:55 UTC-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module L1TEGMultiMerger/'l1tLayer1EG'
   [4] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [5] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 2.5866 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 39434.10339434.103_TTbar_14TeV+2026D88Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D88Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 39634.11439634.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

AddOn Tests

----- Begin Fatal Exception 06-Oct-2022 12:20:54 CEST-----------------------
An exception of category 'NotFound' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
Service no ServiceRegistry has been set for this thread 
----- End Fatal Exception -------------------------------------------------

cmsbuild avatar Oct 07 '22 05:10 cmsbuild

-1

Failed Tests: RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8ded7/28091/summary.html COMMIT: 002f6356539ce9b23b2aa967859c8b9c4ce9b561 CMSSW: CMSSW_12_6_X_2022-10-06-2300/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39625/28091/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 07-Oct-2022 10:12:45 CEST-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module L1TEGMultiMerger/'l1tLayer1EG'
   [4] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [5] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 2.5866 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 39434.10339434.103_TTbar_14TeV+2026D88Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D88Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 39634.11439634.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

cmsbuild avatar Oct 07 '22 10:10 cmsbuild

@cmsbuild Please test

bsunanda avatar Oct 09 '22 03:10 bsunanda

-1

Failed Tests: RelVals RelVals-INPUT Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8ded7/28132/summary.html COMMIT: 002f6356539ce9b23b2aa967859c8b9c4ce9b561 CMSSW: CMSSW_12_6_X_2022-10-08-1100/el8_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39625/28132/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 09-Oct-2022 06:28:40 CEST-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module L1TEGMultiMerger/'l1tLayer1EG'
   [4] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [5] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 3.18723 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 39434.10339434.103_TTbar_14TeV+2026D88Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D88Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 39634.11439634.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

cmsbuild avatar Oct 09 '22 04:10 cmsbuild

@perrotta There were several serious bugs in the code which is corrected here. So if any external file is used in the testing, they are needed to be recreated for the tests. Can the tests be avoided?

bsunanda avatar Oct 09 '22 07:10 bsunanda

@perrotta There were several serious bugs in the code which is corrected here. So if any external file is used in the testing, they are needed to be recreated for the tests. Can the tests be avoided?

@bsunanda this PR must be eventually merged in the master, i.e. it has to run without crashing in it. Please provide all what is needed to run without errors, and test it all together: there is no point in merging a PR that is known to crash once merged.

perrotta avatar Oct 09 '22 08:10 perrotta

@perrotta My point was that if the additional files which are needed in the test be created with the same PR

bsunanda avatar Oct 09 '22 09:10 bsunanda

@perrotta My point was that if the additional files which are needed in the test be created with the same PR

Please create those files and add them as externals, if this is what is needed. If you intended something different, please tell explicitely what is missing here to run without crashing and how to produce it in practice.

perrotta avatar Oct 09 '22 09:10 perrotta

@perrotta There were several serious bugs in the code which is corrected here. So if any external file is used in the testing, they are needed to be recreated for the tests. Can the tests be avoided?

Hi @bsunanda @perrotta Sorry to jump in. May I clarify on the above statement? Do you mean

  • external as mentioned by @perrotta
  • or you mean to recreate MinBias that use for mixing? The failure appears in the workflows that use existing MinBias. Workflow .999 use MinBias to create pre-mixing file.

Actually, I don't understand the failure from PR test. It seems the failure happens because of L1T, but why it fails in D88 which I assume you don't want to touch it. I assume from the PR title (idea of cassette) that it will affect v17 HGCAL only, not v16.

As usual request, would you mind to make a PR with detail in the PR description? If this issue is presented somewhere, link will be useful. Currently, it does not tell us anything on what we expect, what we should do to move this on.

Thanks.

srimanob avatar Oct 10 '22 10:10 srimanob

@perrotta , @salvatore @smuzaffar : Can you please share the workflow number corresponding to MinBias event creation ? We want to use that to validate the current PR.

indra-ehep avatar Oct 10 '22 11:10 indra-ehep

Hi @indra-ehep

Here is the workflow that you can use to produce MinBias GS: 39440.0 2026D88+MinBias_14TeV_pythia8_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal 41040.0 2026D92+MinBias_14TeV_pythia8_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

To check the workflow ID, you can i.e. runTheMatrix.py --what upgrade -n | grep D88 | grep MinBias | grep 14TeV | sed /PU/d

srimanob avatar Oct 11 '22 05:10 srimanob

Ciao all, IIUC, the crash could be due to the fact that the PU library used for testing does not include the fixes that are contained in this PR. It would be nice to understand what those fixes are and why the fixes as proposed in this PR will cause the crash. @jbsauvan FYI: I'd rather L1 HGCAL people be involved in this and, eventually, bless this PR or at least be made aware of the problems that were there and that are not gone. On a final note, the merging of this PR will inevitably cause failures in the testing of all other PRs (again, IIUC what the origin of the failures is), unless the minBias sample is regenerated, which would require a release with this PR merged... Quite a catch-22 situation. Release managers, if that's the situation, do you have any recommendations on how to proceed?

rovere avatar Oct 11 '22 07:10 rovere

assign hgcal-dpg

rovere avatar Oct 11 '22 07:10 rovere

New categories assigned: hgcal-dpg

@felicepantaleo,@rovere,@pfs,@cseez you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Oct 11 '22 07:10 cmsbuild

Hello, The following exception

Exception Message:
TC X1 = 3.18723 out of the seeding histogram bounds 0.076 - 0.58

means that there are trigger cells (and therefore detector cells?) well outside the typical HGCAL acceptance (3.19 >> 0.58 which was about the maximum observed so far). X1 here is r/z where r is the radial distance from the beam. We could make a change in the TPG code to avoid this exception. But is this expected to have cells with r/z>3?

jbsauvan avatar Oct 11 '22 08:10 jbsauvan

Could you provide the DetId which provides this value and how this ratio is calculated in the code?

From: Jean-Baptiste Sauvan @.*** Sent: 11 October 2022 10:52 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Phase2-hgx326X Try to address cassette shift abnormality for HGCal geometry (PR #39625)

Hello, The following exception

Exception Message: TC X1 = 3.18723 out of the seeding histogram bounds 0.076 - 0.58

means that there are trigger cells (and therefore detector cells?) well outside the typical HGCAL acceptance (3.19 >> 0.58 which was about the maximum observed so far). X1 here is r/z where r is the radial distance from the beam. We could make a change in the TPG code to avoid this exception. But is this expected to have cells with r/z>3?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/39625#issuecomment-1274339294, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOTJLWK5SBWKXV6YFFLWCUTGDANCNFSM6AAAAAAQ5O6CJQ. You are receiving this because you were mentioned.Message ID: @.***>

bsunanda avatar Oct 11 '22 14:10 bsunanda