cms-sw
Run3-sim129 Use token rather than label for accessing collections in FastSimulation/ForwardDetectors
PR description:
Use tokens rather than labels for accessing collections in FastSimulation/ForwardDetectors
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32471
- This PR adds an extra 16KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
- code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32471/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32471/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32472
- This PR adds an extra 16KB to repository
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.
It involves the following packages:
- FastSimulation/ForwardDetectors (fastsim)
@cmsbuild, @ssekmen, @civanch, @mdhildreth, @sbein can you please review it and eventually sign? Thanks. @matt-komm this is something you requested to watch as well. @perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58dfc0/28101/summary.html
COMMIT: 7917dff9635b6900683594b3167ae2b3dbdae175
CMSSW: CMSSW_12_6_X_2022-10-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39666/28101/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 10 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3391103
- DQMHistoTests: Total failures: 12
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3391069
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32507
- This PR adds an extra 16KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
- code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32507/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32507/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32510
- This PR adds an extra 20KB to repository
Pull request #39666 was updated. @cmsbuild, @ssekmen, @civanch, @mdhildreth, @sbein can you please check and sign again.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58dfc0/28154/summary.html
COMMIT: e29a395efdd4aa00370417f8c3f14b9c89848fb4
CMSSW: CMSSW_12_6_X_2022-10-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39666/28154/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3392309
- DQMHistoTests: Total failures: 3
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3392284
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
@bsunanda @civanch the suggestion https://github.com/cms-sw/cmssw/pull/39666#pullrequestreview-1135371310 of mine was not included in the last update. Ok, not a big issue, we can live as such, However, since there is a local variable which is defined, assigned and then never used, could you please confirm that such a variable is really not needed anywhere? Since there are other variables with similar and complicate names, I would like to exclude the possibility that there was any mistake somewhere.
@perrotta It gets printed - I believe that is good enough
It doesn't get printed, because the LogVerbatim is commented out. My suggestion was indeed to comment both lines if it is only needed for the Log; or check that it is not needed by anything else instead.
@perrotta the log verbatim is not commented out. Please take a look at the code
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32526
- This PR adds an extra 20KB to repository
Pull request #39666 was updated. @cmsbuild, @ssekmen, @civanch, @mdhildreth, @sbein can you please check and sign again.
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32528
- This PR adds an extra 20KB to repository
Code check has found code style and quality issues which could be resolved by applying following patch(s)
- code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32528/code-format.patch
e.g.
curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32528/code-format.patch | patch -p1You can also runscram build code-formatto apply code format directly
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39666/32530
- This PR adds an extra 20KB to repository
Pull request #39666 was updated. @cmsbuild, @ssekmen, @civanch, @mdhildreth, @sbein can you please check and sign again.
@perrotta the log verbatim is not commented out. Please take a look at the code
Ah, ok @bsunanda : now I see that you already fixed it in a different line with commit e58e298e547de4370e9ffe94d570fb56b78b6b2f That was pretty enough, indeed: would you have answered telling that the fix was applied on a different line I would not have insisted.
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58dfc0/28183/summary.html
COMMIT: 44a383a863f2406a1b5afa9bef759fe133a1fa9a
CMSSW: CMSSW_12_6_X_2022-10-11-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39666/28183/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
@slava77 comparisons for the following workflows were not done due to missing matrix map:
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/20834.0_TTbar_14TeV+2026D88+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/20834.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/20896.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/20900.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/21034.999_TTbar_14TeV+2026D88PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU
- /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-58dfc0/23234.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
Summary:
- No significant changes to the logs found
- Reco comparison results: 6 differences found in the comparisons
- DQMHistoTests: Total files compared: 49
- DQMHistoTests: Total histograms compared: 3392309
- DQMHistoTests: Total failures: 9
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3392278
- DQMHistoTests: Total skipped: 22
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
- Checked 204 log files, 49 edm output root files, 49 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)