Per Östlund

Results 245 comments of Per Östlund

Running automatic conversion scripts shouldn't screw up the formatting unnecessarily

This isn't a frontend issue, it's either a scripting or OMEdit issue, I'm not sure which. The conversion itself is part of the scripting API, but the conversion just updates...

Vectorized zero crossings fail with new frontend

The NF simplifies `max({... for ...})` into `max(... for ...)`, so we get: ```Modelica y1 = max(if u1[j] > 1.0 then u2[j] else u3[j] for j in 1:3); y2 =...

Modelica-Buildings Library (master): Simulation fails at initialization because of Real parameter expressions evaluated to false by the OB

> The question is: why does the NF evaluate `x` during flattening, while it does not evaluate `buiWitETS.bui.QHea_flow_nominal` in the `Buildings.DHC.Loads.Heating.Examples.BuildingTimeSeriesWithETS` model? By default the frontend evaluates function calls with...

Modelica-Buildings Library (master): Simulation fails at initialization because of Real parameter expressions evaluated to false by the OB

> > By default the frontend evaluates function calls with only literal arguments > > OK, that makes sense. Maybe we should reconsider this if impure functions are involved, but...

Modelica-Buildings Library (master): Simulation fails at initialization because of Real parameter expressions evaluated to false by the OB

> How can it be that pure functions only are involved in this case, which involves the reading of a file from the Resources directory? To me, a function that...

Modelica-Buildings Library (master): Simulation fails at initialization because of Real parameter expressions evaluated to false by the OB

I also can't reproduce the issue. I also ran the simulation through valgrind in case it's some kind of memory issue, but it didn't show anything interesting either. Here's a...

Modelica-Buildings Library (master): Simulation fails at initialization because of Real parameter expressions evaluated to false by the OB

> I compared the log I obtained when running the [simulation script](https://github.com/OpenModelica/OpenModelica/issues/13187#issuecomment-2734901388) with [@kabdelhak](https://github.com/kabdelhak), and there is a lot of different stuff there. > > [@perost](https://github.com/perost), would you mind running...

Modelica-Buildings Library (master): Simulation fails at initialization because of Real parameter expressions evaluated to false by the OB

I rewrote `BackendVarTransform` to use `UnorderedMap/Set` instead of the old style hash tables in #13761. I have no idea if that will actually help with this, but `BackendVarTransform` is used...

Improve autocompletion for __OpenModelica annotations

We could also consider changing the formats to be more consistent (keeping the current ones as alternatives so we don't break things of course), since it's a bit odd that...

Improve autocompletion for __OpenModelica annotations

> [@adeas31](https://github.com/adeas31), tooltip suggestion is fine. > > I'm also with [@perost](https://github.com/perost) that we should probably harmonize them. The question is, how do we do that in a backwards compatible...