Per Östlund

Results 245 comments of Per Östlund

#13620 caused a lot of regressions, so for now I decided to revert it (#13631). I looked into what the NB is doing and noticed that the issue isn't just...

> @perost, the `flowCharacteristic` function is defined in `Modelica.Fluid.Machines.BaseClasses.PartialPump` as > > ``` > replaceable function flowCharacteristic = PumpCharacteristics.baseFlow; > ``` > > which has the following definition > >...

>Unfortunately, the actual function input `Pumpe_Qfixed.V_flow_single_init` is incorrectly reported to have unit "m". It should have unit "m3/s", since the [parameter definition in the base class PartialPump](https://github.com/modelica/ModelicaStandardLibrary/blob/master/Modelica/Fluid/Machines.mo#L326) is It has...

Newer versions of OpenModelica also doesn't allow this. Edit: Actually, that's not entirely correct. By default we only issue a warning, it's only in strict mode that we don't allow...

> > If the Boolean expression is false the component (including its modifier) is removed from the flattened DAE, and connections to/from the component are removed by the tool. It...

> PR #10187 partially fixes the issue. Now changing the `controller` value updates the `checkboxes` but does not update the text fields. The text fields depends on `controlMode` parameter which...

The first issue with the conditional should be fixed with #12856. The issue wasn't actually directly related to using a conditional but due to the `y >= 0` expression. The...

This should be fixed by #12853. The issue was that the model contains multiple records called `Stage` in different packages, and in some cases the compiler considered records to be...

It seems #12853 wasn't enough to fix the issue. It works fine in the smaller example I made, but in the full model we still get the wrong result. I...

> @perost is this a big deal to fix? I know what the issue is, it's that a record that needs to be type cast is used to determine a...