Per Östlund

Results 245 comments of Per Östlund

I've now opened #8676 with a first draft that implements `getModelInstance`, but there are a few issues that we need to solve: - [ ] Classes instanced by `getModelInstance` are...

#8683 fixes the issue with EngineV6 that adrpo mentioned in [#8676](https://github.com/OpenModelica/OpenModelica/pull/8676#issuecomment-1064650557). BatchPlant_StandardWater still doesn't work though, for some reason we get some untyped type attributes in it.

The issue with BatchPlant_StandardWater is that we don't type deleted components since that they'll just be removed anyway, so we get issues when we try to dump them. We might...

> But i guess OMEdit doesn't need to see them, so we might as well not dump any of them in the JSON. I thought being able to handle conditional...

Some meeting notes: * Dump the components as an inheritance tree instead of as a flat array so OMEdit knows which components are inherited from where. Maybe add `DAE.ElementSource` to...

> @perost `getModelInstance(Rexroth_Valves.ProportionalValves.Rexroth_2WRCE_4X)` causes the crash. I ran this through both gdb and valgrind, which both showed that it was segfaulting in `IOStreamExt.appendReversedList` but not giving any clear indication why....

You can set a modifier by doing: ```Modelica setComponentModifierValue(MyModelicaLibrary.MyModel, p, $Code(=1)); ``` However, this will modify the loaded model so if you want to e.g. translate the same model multiple...

> * [x] @perost can implement the support for `reinit()` in algorithm sections, activated with the `--allowNonStandardModelica=reinitInAlgorithms` flag. The error message issued if this flag is not activated should suggest...

#9528 changes the error message for reinit statements to mention the flag.