Per Östlund

Results 245 comments of Per Östlund

Strange regression involving Spice models in the MSL

In 4.0.0 `Modelica.Math.log` was defined as `external "builtin" y = log(u)`, which we map to the builtin `log`, while in 4.1.0 it's been changed to be a normal function with...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

The NF does not do such checks, so what you're proposing is that we always run CheckModel after the frontend. Or I guess we might want to only do it...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

Sorry, I missed that you were already doing check model. In that case you get the message: ``` Check of M completed successfully. Class M has 1 equation(s) and 2...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> That was my idea. So is CheckModel part of backend? No, CheckModel is the module used by the API, i.e. what OMEdit uses when you press the Check Model...

Clarifications in Section 3.7 and 5.6.1 regarding "builtin classes"

3.7 also seems to mix the terms operator and function arbitrarily, for example: > Note that when the specification references a **function** having the name of a built-in function it...

Clarifications in Section 3.7 and 5.6.1 regarding "builtin classes"

> > I'm not sure if it's really that useful to make a distinction between functions and operators with function syntax in the first place, it seems rather arbitrary. >...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> @perost, I understand that during checkModel, the NF is called with some flag that disables error generation when instantiating partial classes. In that case, we should not generate an...

Non-partial models which are not locally balanced should generate an error in the NF when checking and trying to simulate

> The first piece of information is there, so that's easy, just check if the two numbers are the same. The question is, can the NF return the second and...

Buildings.Templates.Plants.Controls.StagingRotation.Validation.EquipmentEnable causes the runtime to crash due to buffer overflow

It seems to be used to read the input XML file [here](https://github.com/OpenModelica/OpenModelica/blob/master/OMCompiler/SimulationRuntime/c/simulation/simulation_input_xml.c).

Buildings.Templates.Plants.Controls.StagingRotation.Validation.EquipmentEnable causes the runtime to crash due to buffer overflow

I did some debugging and the hashmap error seems to be a red herring. The actual issue seems to be a buffer overflow caused by #12969, which is the reason...