Dean Herbert

Results 1962 comments of Dean Herbert

The deeper story is that the delay in disposal is roughly equal to the maximum timeout of all actively loading drawables already in `SCHEDULER_LONG_LOAD`. In this scenario, avatars are the...

What's the idea here? Remove things we're not using only to add them back when we end up using them?

For future reviewer, these can be reviewed when merged: https://github.com/ppy/osu/blob/c3396a93a63262547ad0c3ead389f5d702109357/osu.Game.Tests/Visual/SongSelectV2/TestSceneCollectionDropdown.cs#L259-L261 https://github.com/ppy/osu/blob/d5fe7e20be19cc8431382ccd5b74e87d7091dfa9/osu.Game.Tests/Visual/SongSelect/TestSceneCollectionDropdown.cs#L268-L270 (Just removing from my local todo list)

This is due to the volume of game effects being different in lazer compared to stable (lazer drops the volume of music by 20% to give more head room for...

Maybe it should read "Create Team" when you aren't already in one? not sure... ;

The intention was to support lazer, but if we limit the restrictions to just lazer it's only a matter of time before the abuse begins to hit the lazer API...

I believe this may be fixed via https://github.com/ppy/osu/pull/35966.

I'm not sure about this one. It feels like test play should be used for this. It's not something I can see anyone leaving enabled permanently, which makes it a...

The UX i imagined for the editor was to have the "test" play not transition to its own screen, but just hide the editor UI and leave the gameplay remaining....