Dean Herbert
Dean Herbert
There's no real reason apart from it being the legacy term we use internally (still) as an identifier.
#12328 is this issue 😄 . @notbakaneko are you taking this change on?
I haven't considered the new code splitting, structure, DI usage or anything. That's going to take hours / days of consideration. Hard to say if any of this abstraction is...
Also seen in https://github.com/ppy/osu-web/pull/12431.
Can we merge this and get it over with? Or still stuck on some tooling?
Before entertaining this change, can you explain how "notes" and "both" differ? To my brain both those options should not need to exist.
One remaining question I have is whether the default should be switched to "notes", as to work better for all key counts.
I believe the check was for things like autopilot where the cursor could be hidden?
Root cause is `HoldToConfirmContainer` not getting disposed on time: https://github.com/ppy/osu/blob/0ebc90462d2c06884e9004f670ab2800837e0865/osu.Game/Overlays/HoldToConfirmOverlay.cs#L64-L69 We can easily fix this locally, but it's still leaving disposal in a weird unknown state (something is pending on...
That's fine as a local fix as I hinted at... if we're okay with the rest of player in a state where it's in the background loading avatars for potentially...