Dean Herbert

Results 1970 comments of Dean Herbert

I'm not going to review this yet. There's enough wrong/unclear with this that I'd want others to put in the effort (or maybe just re-read it a few days later...

If things are still legible at 9 then changing it is fine, yes. The cutoff was arbitrarily chosen by @frenzibyte, intending to be the point where it would stop being...

> I also want to mention that the footer doesn't disappear after starting the beatmap too. It can't, because it contains the back button. If it was to disappear there...

@nekodex did you ever do that cross fade thing? they is the fix for this issue, and honestly should be a very quick one to implement.

@Speed-sters if you're able to build locally, could you please test out the fix on #33600?

> This is what terrifies me every time with one of these skinning PRs, the thing is inscrutable and has inscrutable lookup paths (I read the diff and couldn't tell...

> The issue of legacy combo counter displaying in triangles skin is actually fixed when merging master to this PR Can you link to the PR which changed/fixed this?

> Solving this is quite simple (dead giveaway even), I've gone through it in this commit: https://github.com/frenzibyte/osu/commit/d2be5553dd041263f5efdcb9f6e60f77796965a9. Tested to work with all skins in all rulesets. I don't find this...

Unassigning @frenzibyte since he seems to have dropped this. For the next person to look at this, it *may* make sense to pull in a commit in the comment above...

This is nightmare level to solve, since the server is returning localised strings. Probably have to use the `Id` that is also returned and create a local mapping.