Dean Herbert

Results 1970 comments of Dean Herbert

Please update the PR description to explain in detail what this does. Users need documentation of this in changelogs and I'm not going to go through and do this myself...

How are you testing this btw? There doesn't look to be a test scene setup.

I disagree with this being a setting on perfect mod. That's just too much overloading. That said, I'd also choose a better name for this mod, since it has nothing...

It baffles me that we can get this far and still have the same issue remaining. cc/ @Susko3

Proposal 1: two methods ```diff diff --git a/osu.Game.Rulesets.Mania/Mods/ManiaModPerfect.cs b/osu.Game.Rulesets.Mania/Mods/ManiaModPerfect.cs index abcee50e82..3e4ae9c68f 100644 --- a/osu.Game.Rulesets.Mania/Mods/ManiaModPerfect.cs +++ b/osu.Game.Rulesets.Mania/Mods/ManiaModPerfect.cs @@ -9,7 +9,7 @@ namespace osu.Game.Rulesets.Mania.Mods { public class ManiaModPerfect : ModPerfect { -...

I'll tidy up the second proposal and commit it to this branch.

Sorry for the delay, lost track of this one. I've applied the diff with multiple fixes and improvements. Will require a re-review from someone else with fresh eyes.

Relevant stable implementation ```csharp private static bool ensureFreeSpace() { const ulong requiredBytes = 1024 * 1024 * 128; ulong systemBytesAvailable, totalBytes, bytesAvailable; Native.GetDiskFreeSpaceEx(Environment.CurrentDirectory, out bytesAvailable, out totalBytes, out systemBytesAvailable); if...

Does this work with the github "pre-release" parameter? The hardest part of making this work is going to be the deployment setup with github actions and our existing flows for...