osu icon indicating copy to clipboard operation
osu copied to clipboard

Song select v2: when game is set to non-english language pressing things in detail section such as "genre" or "language" doesn't work correctly

Open 75aosu opened this issue 6 months ago • 3 comments

Type

Game behaviour

Bug description

search doesn't work correctly (it just copys text in that lauguage and not in original language)

Screenshots or videos

https://github.com/user-attachments/assets/a619df2a-86b4-4397-b1b1-fae6ae7cf784

Version

2025.605.1

Logs

compressed-logs.zip

75aosu avatar Jun 05 '25 10:06 75aosu

This is nightmare level to solve, since the server is returning localised strings. Probably have to use the Id that is also returned and create a local mapping.

peppy avatar Jun 10 '25 04:06 peppy

That's not really the main problem. We can do something like this: https://github.com/ppy/osu/blob/85eef1bc3ae1cdd4ecbabf6f760aab272e5b9a76/osu.Game/Overlays/BeatmapSet/MetadataSectionGenre.cs#L22-L27

The main problem is that genre and language is not stored yet, and search is instead relying on mapper tags, which may not have them (e.g. disco prince) because having genre and language in tags ~was only enforced since aug 2024~ actually that just moves stuff, rule was applied before that.

Edit: rule was added dec 2018, I think (just genre/language in English)

Best effort is still displaying them localised (correctly using code above) but having search put the English term, but most old maps will not be searchable.

Joehuu avatar Jun 11 '25 01:06 Joehuu

We shouldn't be relying on mapper tags. That sounds absolutely wrong.

peppy avatar Jun 11 '25 07:06 peppy