Dean Herbert
Dean Herbert
Is this supposed to compile?
I didn't see the most recent comments, but came here to review as a whole and also look into test failures. Something like this should fix failures: ```diff diff --git...
Splitting the two out felt good for keep the classes small, but I agree that maybe they should be combined. I'm fine with that being done elsewhere / later. Curious...
Probably duplicate of https://github.com/ppy/osu/issues/28928.
This is kiiinda how notifications work. Player only blocks the first exit request, but the restart notification is very persistent due to using `PerformFromScreen`: https://github.com/ppy/osu/blob/12a148d1084b1a6f11525ff16c223ecb6ddd6927/osu.Desktop/Updater/SquirrelUpdateManager.cs#L150-L155 https://github.com/ppy/osu/blob/f068b7a521c8ce8b29da9161f7ef4c7ab92429ec/osu.Game/OsuGame.cs#L857-L861 I can think of...
I'll see if I can stop it showing during gameplay.
@bdach which of these would you prefer? ```csharp // Copyright (c) ppy Pty Ltd . Licensed under the MIT Licence. // See the LICENCE file in the repository root for...
SDL3 is not the default mode the game runs in. Can you confirm you are not forcing running in SDL3?
Probably a framework-side fix. Although may be hard as the `IsPresent` state will not be updated in all cases (ie. when a parent is hidden). Isn't the first time something...
> Since the issue is caused by the user being able to exit the overlay with keyboard, it may be wiser to end a drag when a key (or any...