Dean Herbert

Results 1970 comments of Dean Herbert

Can we not keep the ctrl-shift for sample points? I feel like we may want to keep alt for other usages in the future. Or leave it unused.

Sliders aren't holds. The mod should not be named after holds when it's changing sliders.

Hmm, I dunno what edge cases making them interactive will lead to. We'll need to ensure none of the buttons on them actually work, at very least.

This is a bit ugly IMO. I gave the proposal I made on discord a try and it's pretty low effort: https://github.com/ppy/osu/compare/master...peppy:osu:detached-beatmap-cache?expand=1 Remaining work is to tidy up the subscription...

> Why is GetDetachedBeatmaps() on a 10s timeout after which it just fails? Don't dwell on it, just banned symbols. > I'd hope the detach can be done in a...

@bdach i still need to do a sanity and test pass, but how is this looking for you now? https://github.com/ppy/osu/compare/master...peppy:osu:detached-beatmap-cache?expand=1

Going to close this for now based on https://github.com/ppy/osu/pull/29311#issuecomment-2385563246 and the fact that it's only a few lines of change.

This was 100% intentional to allow for pausing to ramp the pitch down like a tape/record player. That functionality was removed so I guess we could change this to work...

Should be kinda resolved via https://github.com/ppy/osu/pull/30387.