Robert Pająk

Results 706 comments of Robert Pająk
trafficstars

SIG meeting: Looks good for the Go SIG. The only feedback was that it would be safer to have `EMPTY` a new type (distinct from `INVALID`) and creating empty values...

FYI, https://github.com/open-telemetry/opentelemetry-go/pull/6431#issuecomment-2722350315. I edited the issue description.

**Proposal A - Extend Processor** Below is a proposal mostly based on how Go Logs SDK currently implements `Logger.Enabled`. Spike: https://github.com/open-telemetry/opentelemetry-go/pull/5816 The idea is to add an `OnEnabled` operation to...

**Proposal B - Add filtering via Filterer** Below is a proposal inspired by sampling design in tracing SDK. Spike: https://github.com/open-telemetry/opentelemetry-go/pull/5825 The idea is to add a new abstraction named `Filterer`...

> I'm a little concerned that by "defining" the way that "enabled" should be implemented (especially adding layers of filtering (as part of the required implementation)) would (potentially) worse from...

> I think it's fine to define "what" options should be used (ie the parameters) to "check" whether something is enabled or not and this should be limited. > If...

> What about adding a severity level as part of the [logger config](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#loggerconfig)? I think that it is reasonable to improve the logging configuration than introducing a new concept. It...

> If we unify on the logger config, we would not be able to have different severity level support for different processors. [...] This issue is also present in [Proposal...

Wouldn't it be acceptable if the SDK supports to multiple ways to implement Enabled? E.g. [**Proposal A**](https://github.com/open-telemetry/opentelemetry-specification/issues/4207#issuecomment-2352291363) and [**Proposal C**](https://github.com/open-telemetry/opentelemetry-specification/issues/4207#issuecomment-2362290968). I think that an ability to configure a logger to...

Given we already have a few proposals and a prototype in Go. Shouldn't this issue be no longer a blocker for https://github.com/open-telemetry/opentelemetry-specification/issues/4208? CC @open-telemetry/technical-committee