Robert Pająk

Results 392 comments of Robert Pająk

I think that we can simply improve the documentation to make it clear that value set via `_ENDPOINT` can be altered via `WithInsecure`, `WithEndpoint` and `WithURLPath` options. While I am...

@JakeCooper I tried my best to improve the docs in https://github.com/open-telemetry/opentelemetry-go/pull/4695. I also plan to improve the https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp#WithEndpoint documentation of to include something like > This endpoint is specified as...

@dmathieu What do you think about updating the issue description to propose adding e.g. `WithEndpointURL` to `otlptracehttp` and `otlpmetrichttp`?

@open-telemetry/go-instrumentaiton-maintainers I think this is good to merge.

Lint failing: https://github.com/open-telemetry/opentelemetry-go/actions/runs/4328860180/jobs/7570921576

@tonyo Can you please double-check if releases starting from https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.20.0 are solving the issue you described?

I was working on something similar recently for .NET and here is the result: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/tree/main/examples/demo Maybe it will help... 😉

> I don't think this is worth added to the Go implementation. It was added to the specification for languages that may come with auto-instrumented code. The Go implementation requires...

> Are there more changes required before this can merge? "This branch has conflicts that must be resolved" 😉

@prodion23 Are you planning to refresh the PR and address the comment(s)?