opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

added version.go and test file for issue 2143

Open ChillOrb opened this issue 2 years ago • 4 comments

  1. As per #2143 , added un-exported func version() for sdk/metrics and sdk/trace and added test cases in the same sdk module.

ChillOrb avatar Feb 05 '23 01:02 ChillOrb

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: ChillOrb / name: Rakshit Parashar (9ef3922f7f7c68e1b8ae440384d0343af1152d13)

Codecov Report

Merging #3677 (847d7ac) into main (7971a12) will decrease coverage by 0.1%. The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3677     +/-   ##
=======================================
- Coverage   82.8%   82.8%   -0.1%     
=======================================
  Files        177     179      +2     
  Lines      13494   13498      +4     
=======================================
+ Hits       11178   11180      +2     
- Misses      2095    2097      +2     
  Partials     221     221             
Impacted Files Coverage Δ
sdk/metric/version.go 100.0% <100.0%> (ø)
sdk/trace/version.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

codecov[bot] avatar Feb 06 '23 03:02 codecov[bot]

Added license info in sdk/metric/version_test.go

ChillOrb avatar Feb 06 '23 04:02 ChillOrb

@open-telemetry/go-instrumentaiton-maintainers I think this is good to merge.

pellared avatar Feb 28 '23 07:02 pellared

Lint failing: https://github.com/open-telemetry/opentelemetry-go/actions/runs/4328860180/jobs/7570921576

pellared avatar Mar 06 '23 09:03 pellared