Robert Pająk

Results 829 comments of Robert Pająk

1. Where is the log file created? 2. Is it possible to change the logging message template?

I think it is related to this one: https://github.com/open-telemetry/opentelemetry-specification/pull/3853

> Then it was changed to the key/value list due for performance improvements. This proposal is also due for performance improvements. > the OTel Collector is built on top of...

> I think the data consistency and deterministic processing across the OpenTelemetry project are more important than the performance degradation of one instrumentation library. It is not only performance degradation...

@mx-psi @TylerHelmuth @dmitryax I want to point out that this PR does NOT require making any changes in the Collector if the last (or any) item with the same key...

Added to PR description: > The OTLP exporters can have a configuration to deduplicate key-val pairs before sending the data to satisfy receivers that require them to have unique keys.

> If a sizeable part of the OpenTelemetry ecosystem is not able to use this feature at all, what's the point of making this change? Because it gives significant performance...

> For the sake of discussion, is there any data about the actual performance impact of deduplication in the log pipeline at an SDK level? Please read the description. There...

> I'm very much against this change. This breaks a known invariant and forces all backends to deal with the issue. I don't think the benefit outweighs the overall cost....