Pedro M. Baeza

Results 2109 comments of Pedro M. Baeza

Isn't this what https://github.com/OCA/partner-contact/tree/13.0/partner_data_vies_populator does?

Please check Travis. There's no extra commits to rescue from 8.0? Check migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

Yes, we need them because they are translations, but you have to squash them together. What we don't want is that detailed history. Please follow https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 and https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests guides

I see it correct. Another possible improvement in the payment order is to have a `store=False` field to set them, and propagate to the existing lines. Remember to put the...

Yeah, I think so. The journal items in this account are the distribution of the benefits, so it shouldn't go anywhere in the P&L. What do you think, @StefanRijnhart ?

Let me explain: that one shouldn't go to anywhere. It's an special type that is recognized by Odoo enterprise reports or OCA financial reports to accumulate all the balances from...

Maybe it's a problem here on the hook: https://github.com/OCA/account-financial-reporting/blob/13.0/account_tax_balance/hooks.py#L26

If enough reviewers confirm that the change is stable enough, it can be merged in 12.0, but my fear is to provoke side effects in a relative old version.