Pedro M. Baeza

@lauracvilla no. Please don't hijack threads.

This is not possible, as https://github.com/OCA/bank-payment/pull/936/files#diff-c44811bc7189570a631438d2dca538756d8ad24b26ced88bfd5df3ab44b74f60R92 should give a value. Anyways, if you want to make sure, add there an ` or ""` part.

Now we need steps to reproduce the problem from the scratch. How a journal item doesn't have neither `name` nor `ref` set?

Why the partial payment influences this?

Thanks for the extra information. I don't see where this method is being called in current chain. Can you point me? Another interesting thing is to add a comment in...

OK, but this is still not answering the original question: why both `ref` and `name` are empty.

So that confirms that is not False, but "". Anyways, putting this safeguard is not too much, so I stop being nitpicking.

The command was not correct (a missing `a`) /ocabot merge patch

Approved

For the super missing, just include the return, although no value is returned on super: ```python def _get_invoiced(self): res = super()._get_invoiced() return res ``` The problem in the tests seems...