bank-payment icon indicating copy to clipboard operation
bank-payment copied to clipboard

[15.0][MIG] account_payment_purchase

Open airlessproject opened this issue 2 years ago • 6 comments

Original PR:

https://github.com/OCA/bank-payment/pull/877

Added 3 fixes: https://github.com/airlessproject/bank-payment/commit/0f12d353507fe9413dfa5558ba706c021b77927e (as suggested by https://github.com/MiquelRForgeFlow)

https://github.com/airlessproject/bank-payment/commit/03ca6d0f7dd54892f06a475da09054bbce68b7bf (fix for unit test) https://github.com/airlessproject/bank-payment/commit/770e02cad14428cf965d7961192eaf034a32d921 (fix for unit test)

airlessproject avatar May 20 '22 11:05 airlessproject

@airlessproject Can you check failed tests please?

Shide avatar Jun 01 '22 13:06 Shide

@airlessproject Can you check failed tests please?

the errors are in other module (account_payment_order) Module account_payment_purchase which is migrated in this PR doesn't have any errors

Should I try to fix the errors in account_payment_order in this PR?

airlessproject avatar Jun 01 '22 14:06 airlessproject

@airlessproject Can you check failed tests please?

the errors are in other module (account_payment_order) Module account_payment_purchase which is migrated in this PR doesn't have any errors

Should I try to fix the errors in account_payment_order in this PR?

@airlessproject Put the tests in post_install: https://github.com/OCA/bank-payment/runs/6524133862?check_suite_focus=true#step:8:139

Shide avatar Jun 09 '22 15:06 Shide

@Shide Now the tests are failing in 2 assertions. It seems that the account_payment_order module indeed has some issues in the unit tests.

However the tests in account_payment_purchase which is migrated in this PR again don't have any errors. Please let me know what can we do next.

Thanks!

airlessproject avatar Jun 09 '22 20:06 airlessproject

Could you rebase and run tests again?

ao-landoo avatar Aug 11 '22 12:08 ao-landoo

@ao-landoo, @airlessproject originally did this for one of my projects, and they've since moved on to other projects. I've opened the new PR #952 which is rebased and passing.

@gelo-landoo may also want to re-approve that one.

Sorry for the messiness.

aisopuro avatar Aug 16 '22 14:08 aisopuro

Superseded by #952

pedrobaeza avatar Aug 18 '22 14:08 pedrobaeza