account-invoicing icon indicating copy to clipboard operation
account-invoicing copied to clipboard

15.0 mig purchase stock picking return invoicing

Open 26hpredraglazarevic opened this issue 2 years ago • 7 comments

26hpredraglazarevic avatar May 18 '22 08:05 26hpredraglazarevic

@pedrobaeza @MiquelRForgeFlow hi guys, since I'm first-time contributor could you please approve workflows, so checks can run. Also if you are available to do code review, that would be much appreciated. Thank you in advance.

26hpredraglazarevic avatar May 18 '22 08:05 26hpredraglazarevic

Only @OCA/community-maintainers can approve workflows.

MiquelRForgeFlow avatar May 18 '22 09:05 MiquelRForgeFlow

Only @OCA/community-maintainers can approve workflows.

Thanks for the info Miguel. @OCA/community-maintainers since I'm first-time contributor could you please approve workflows, so checks can run. Also if you are available to do code review, that would be much appreciated. Thank you in advance.

26hpredraglazarevic avatar May 18 '22 11:05 26hpredraglazarevic

Approved

pedrobaeza avatar May 18 '22 12:05 pedrobaeza

@pedrobaeza can u help me with this pull request, who do I contact regarding Review. Three tests that are failing are:

  1. pylint, but I can't fix it bcs its Missing return (super is used) in methods _get_invoiced and _compute_invoice and there is no returned value on method's super
  2. unit tests on account_invoice_fiscal_position_update
  3. unit tests on account_invoice_fiscal_position_update

26hpredraglazarevic avatar May 24 '22 08:05 26hpredraglazarevic

For the super missing, just include the return, although no value is returned on super:

def _get_invoiced(self):
    res = super()._get_invoiced()
    return res

The problem in the tests seems something outside this PR.

pedrobaeza avatar May 24 '22 10:05 pedrobaeza

@26hpredraglazarevic please could you rebase?

MiquelRForgeFlow avatar Jun 29 '22 10:06 MiquelRForgeFlow