account-invoicing
account-invoicing copied to clipboard
15.0 mig purchase stock picking return invoicing
@pedrobaeza @MiquelRForgeFlow hi guys, since I'm first-time contributor could you please approve workflows, so checks can run. Also if you are available to do code review, that would be much appreciated. Thank you in advance.
Only @OCA/community-maintainers can approve workflows.
Only @OCA/community-maintainers can approve workflows.
Thanks for the info Miguel. @OCA/community-maintainers since I'm first-time contributor could you please approve workflows, so checks can run. Also if you are available to do code review, that would be much appreciated. Thank you in advance.
Approved
@pedrobaeza can u help me with this pull request, who do I contact regarding Review. Three tests that are failing are:
- pylint, but I can't fix it bcs its Missing
return
(super
is used) in methods _get_invoiced and _compute_invoice and there is no returned value on method's super - unit tests on account_invoice_fiscal_position_update
- unit tests on account_invoice_fiscal_position_update
For the super missing, just include the return, although no value is returned on super:
def _get_invoiced(self):
res = super()._get_invoiced()
return res
The problem in the tests seems something outside this PR.
@26hpredraglazarevic please could you rebase?