Martin Pecka

Results 179 comments of Martin Pecka

Thanks for the reference. With you saying there is a chance and will to accept the required change, I'll consider sending the PR, but no earlier than in October. I'm...

Yes, but it's not top priority at this moment. Are there any release deadlines closing?

Solution for proper running using simulation time has been just proposed: https://github.com/chvmp/champ/pull/48 .

Just call `git pull --recurse-submodules` in the directory where you cloned champ. I'm not sure about Noetic compatibility, but I don't see any general problem for it to not work.

OMG lost a few hours debugging this on G11!!! Couldn't there be at least some warning in G11 when user code calls `SphericalFromLocal` etc.? And also when there is a...

Thanks for the PR, it looks useful. I'm also not qualified to assess the GPU parts of the PR. After a quick skim trough it, there are however some issues...

Hmm, going through the code once again, I'm more and more convinced it balances on the very edge of needing to break API or ABI compatibility. The [contribution guidelines](https://classic.gazebosim.org/tutorials?tut=contrib_code&cat=development) require...

This PR is similar to https://github.com/ros/ros_comm/pull/2367 but chose the other mentioned approach by using `datetime`. This PR also fixes both places where time strings can appear. Moreover, this PR adds...

@rafa-martin Thanks for stopping by. Would you be able to review this PR? In the low maintenance mode Noetic has, non-maintainer reviews are almost a requirement to get things moving.