pdeffebach

Results 429 comments of pdeffebach

Here is the problem in particular: ``` julia> using DataFrames julia> using DataFramesMeta: @transform julia> df = DataFrame(x = [1, 2]); julia> @transform df :y = :x .+ :x .^...

Cool that seems to have fixed it. Great, I was worried that I would be really out of luck. I will make a PR for this after I merge #307

Thank you for the bug report! I think I understand what's going on but it will take a few days to look into it more fully.

It's more mysterious than that, though. On 1.7.2 ``` julia> @by( df, :x, :a = maximum(:y .* :z) ) ERROR: UndefVarError: .* not defined Stacktrace: [1] top-level scope @ ~/.julia/packages/DataFramesMeta/kWkhX/src/macros.jl:2056...

Okay, so one solution would be to de-construct `.*` etc. to `Expr(:., :*)` I will file an issue in Julia Base so people are aware of this, which I think...

Sorry for not addressing this. A workaround, which isn't really sensible, is to add "junk" in the expression ``` julia> @by( df, :x, :a = begin 1; maximum(:y .* :z)...

Yes, it should exist for all macros.

I'm having a hard time making an MWE ``` julia> macro make_composed(x, y) esc(:(∘($x, $y))) end; julia> function make_composed2_helper(x, y) Expr(:call, ∘, x, y) end; julia> macro make_composed2(x, y) esc(make_composed2_helper(x,...

It's really hard to tell the rules about when `.*` survives and when it becomes `Expr(., *)`. I will have to explore more.

I did not see this! I think gmail is filtering github notifications from this Repo. No, I don't think we should have `@filter` instead of `@rsubset`. Since we can do...