Patrick Walton comments

Results 269 comments of


                                            Patrick Walton

Implement clearcoat per the Filament and the `KHR_materials_clearcoat` specifications.

On NVIDIA, warp occupancy and register count are identical both before and after this PR. ![Screenshot 2024-05-01 150843](https://github.com/bevyengine/bevy/assets/157897/aa7f6737-3073-4d2c-9530-ab2ea789dc6e) ![Screenshot 2024-05-01 151432](https://github.com/bevyengine/bevy/assets/157897/2c294445-fa7d-4243-b987-214271d2c32c)

Implement clearcoat per the Filament and the `KHR_materials_clearcoat` specifications.

@NthTensor It only has one approval. Having a second approval would be very helpful.

Implement clearcoat per the Filament and the `KHR_materials_clearcoat` specifications.

Closing as I am burned out and have no motivation to get this landed anymore.

Implement clearcoat per the Filament and the `KHR_materials_clearcoat` specifications.

Updated.

Implement volumetric fog and volumetric lighting, also known as light shafts or god rays.

I think the CI failure is spurious.

Implement volumetric fog and volumetric lighting, also known as light shafts or god rays.

Closing as I am burned out and have no motivation to get this landed anymore.

Implement fast depth of field as a postprocessing effect.

I've disabled this feature entirely on WebGL 2. There are two problems here: 1. WebGL 2 has no support for multisample depth textures. 2. Naga has a bug whereby it...

Implement fast depth of field as a postprocessing effect.

Closing as I am burned out and have no motivation to get this landed anymore.

Implement fast depth of field as a postprocessing effect.

I reduced the support of the Gaussian blur and did the two-at-a-time optimization, which should make the Gaussian blur version faster than the bokeh. This should be ready for review...

Meshlet single pass depth downsampling (SPD)

Which parts do you want me to review? Presumably `downsample_depth.wgsl`? Anything else?