Patrick Walton comments

Results 269 comments of


                                            Patrick Walton

Implement irradiance volumes.

Don't merge yet. The CI failure is legit.

Implement minimal reflection probes (fixed macOS, iOS, and Android).

@JMS55 Sure, I think I can do that. Note that this will require rewriting much of the patch as I will have to merge the conditional definitions of `RenderViewBindGroupEntries` into...

Implement minimal reflection probes (fixed macOS, iOS, and Android).

@mockersf How are you testing this on Android? I tested `cd examples/mobile && cargo apk run` and it works fine on my Pixel 7 Pro. Perhaps this is Android-GPU-specific? As...

Implement minimal reflection probes (fixed macOS, iOS, and Android).

Gotcha, I'll try on the simulator next. I suspect that SwiftShader has a relatively low limit while modern Mali has a higher limit. I can try to detect the maximum...

Implement minimal reflection probes (fixed macOS, iOS, and Android).

> it doesn't crash on the Android simulator if I check on `render_device.limits().max_storage_textures_per_shader_stage` OK, I check that now. Seems to work on the default emulator that comes with Android Studio.

Renderer optimization tracking issue

#12773 also effectively bypasses `encase` on platforms where compute shaders are present, since `MeshInputUniform` uses `bytemuck`.

Implement opt-in sharp screen-space reflections for the deferred renderer.

This should be ready for review now.

Implement opt-in sharp screen-space reflections for the deferred renderer.

I renamed `ScreenSpaceReflections` to `ScreenSpaceReflectionsSettings` and added a bundle, `ScreenSpaceReflectionsBundle`.

Implement opt-in sharp screen-space reflections for the deferred renderer.

@aevyrie Yes, I agree. I think that should be a followup as it'll be a decent amount of code.