Patrick Walton comments

Results 269 comments of


                                            Patrick Walton

Implement the Bevy Remote Protocol (BRP).

`smol` hasn't had any commits for 2 months. Do we still want to rely on it?

Implement the Bevy Remote Protocol (BRP).

Ok, this is now using `smol` instead of Tokio.

Implement the Bevy Remote Protocol (BRP).

I'm putting this as "needs review" because I'm waiting on @coreh to look at it before doing more.

Implement the Bevy Remote Protocol (BRP).

There actually aren't as many components as you might think -- no more than 50 IIRC. I don't think pagination is necessary. Maybe in the future.

Implement the Bevy Remote Protocol (BRP).

@LegNeato Can you elaborate as to what you mean?

Pack multiple vertex and index arrays together into growable buffers.

I've addressed all the review comments as much as I feel is appropriate. From running the examples on WebGL the performance seems fine. I can't do very in-depth performance analysis...

Pack multiple vertex and index arrays together into growable buffers.

The merge fallout is fixed. This is ready to be merged again.

Put spawners into an array in the shader instead of using dynamic offsets.

I'm not sure why formatting is failing; it seems to be that perhaps the linter was upgraded?

Improve frustum culling of skinned meshes through per-joint bounds

Oh nice, I just filed #21845 for the rest pose approach.