Paul Cody

~Anyone aware of a migration tool that does this properly?~ Update: in my hands, the presence of a `node_modules/` tree changes the interpretation of `pnpm import`. Once I deleted the...

Checked out rules_scala at `73f5d1a7da081c9f5160b9ed7ac745388af28e23` and built the custom deploy jar as follows: I then edited the test.sh file to use the bazel 5 version: ```diff build_local_jacocorunner() { - $root_dir/scripts/build_jacocorunner/build_jacocorunner.sh...

The zip file can be consumed as an `http_archive` as follows: ```bazel http_archive( name = "rules_scala_jacocorunner", sha256 = "1e21d640ac5e39bff30c6255b2de389b0a53adf2338aeeeb5a656b13de11ba2b", urls = ["https://github.com/bazelbuild/rules_scala/files/10109719/jacoco-coverage-73f5d1.zip"], build_file_content = """ filegroup( name = "jar", srcs...

A custom scala_toolchain was setup: ```bazel load("@io_bazel_rules_scala//scala:scala_toolchain.bzl", "scala_toolchain") scala_toolchain( name = "jacocorunner_toolchain_impl", jacocorunner = "@rules_scala_jacocorunner//:jar", unused_dependency_checker_mode = "error", visibility = ["//visibility:public"], ) toolchain( name = "jacocorunner_scala_toolchain", toolchain = "jacocorunner_toolchain_impl", toolchain_type...

The toolchain was registered in the `WORKSPACE`: ```bazel register_toolchains( "//bazel_tools/scala:jacocorunner_scala_toolchain", ) ```

Salient `.bazelrc` flags: ```rc build --java_language_version=17 build --tool_java_language_version=17 build --java_runtime_version=remotejdk_17 build --tool_java_runtime_version=remotejdk_17 coverage --combined_report=lcov coverage --coverage_report_generator="@bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:Main" ```

Despite all this, coverage.dat files are always empty: ``` bazel coverage //common/auth:tests INFO: Invocation ID: 9a653f7d-2864-4208-80cd-aa4bdb558f10 INFO: Using default value for --instrumentation_filter: "^//common/auth[/:]". INFO: Override the above default with --instrumentation_filter...

``` bazel version Build label: 5.1.1- (@non-git) Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Sat May 21 09:38:24 2022 (1653125904) Build timestamp: 1653125904 Build timestamp as int: 1653125904 ```

cc @gergelyfabian any suggestions here?

Indeed things *are* working in that example, with the custom `JacocoCoverage_jarjar_deploy.jar` uploaded to this issue. ``` shasum -a256 tools/JacocoCoverage_jarjar_deploy.jar 66a0a251086895241063adf23f2773bd7ebe1ba0762612871a0d50d8c81a58fd tools/JacocoCoverage_jarjar_deploy.jar ``` ``` bazel-scala-example % git status On branch jacoco_coverage_fix_new...