Philippe Canal

Results 332 comments of Philippe Canal

Yes, it could help. The class 'renaming' io-rule is more sturdy that the data member specific rules as the former do not require the caching (on the input as-is) that...

This is consistent with the rules not been scheduled/applied properly (i.e. here properly not running)(and most likely one of the currently-being-worked-on issues). Using the renaming rule ought to work around...

Note: this change obviously allows 'new' code to work better (allows use of user-defined `::data`) but invalid any existing code that (intentionally or not) rely on the global `using namespace...

The best solution is to simply remove the ClassImp which are deprecated and offer very little value added. Another solution is to simply add an empty line about of the...

Could you clarify how you see this related to our project?

@hahnjo which of the variable in core/io were you concerned about?

This failing case is on root-fedora30-1.cern.ch with ``` /usr/bin/cmake -DCMAKE_BUILD_TYPE="Debug" -Dminimal="ON" -Droottest="ON" /build/workspace/manual/root -G Ninja ```

On the other the jenkins generated configuration works: ``` cmake -DCMAKE_BUILD_TYPE="Debug" -DCMAKE_CXX_FLAGS="-UNDEBUG" -DCMAKE_CXX_STANDARD="14" -DCMAKE_INSTALL_PREFIX="/build/workspace/root-pullrequests-build/install" -DLLVM_ENABLE_ASSERTIONS="On" -Dalien="Off" -Darrow="Off" -Dasimage="On" -Dbuiltin_afterimage="On" -Dbuiltin_cfitsio="Off" -Dbuiltin_davix="On" -Dbuiltin_fftw3="Off" -Dbuiltin_freetype="Off" -Dbuiltin_ftgl="On" -Dbuiltin_gl2ps="On" -Dbuiltin_glew="On" -Dbuiltin_gsl="Off" -Dbuiltin_lz4="On" -Dbuiltin_lzma="On" -Dbuiltin_openssl="Off"...