root icon indicating copy to clipboard operation
root copied to clipboard

Published 20 hours ago • verified publisher icon root-project

[DF] Apply some include fixes from include-what-you-use

Open eguiraud opened this issue 3 years ago • 10 comments

This is not all the suggested fixes, but it should be an improvement w.r.t. the current situation.

eguiraud avatar Aug 09 '22 12:08 eguiraud

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 09 '22 12:08 phsft-bot

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-09T12:14:58.057Z] FAILED: tree/dataframe/CMakeFiles/ROOTDataFrame.dir/src/RCutFlowReport.cxx.o
  • [2022-08-09T12:14:58.315Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDF/RCutFlowReport.hxx:56:36: error: declaration of ‘operator[]’ as non-function
  • [2022-08-09T12:14:58.315Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDF/RCutFlowReport.hxx:56:29: error: expected ‘;’ at end of member declaration
  • [2022-08-09T12:14:58.315Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDF/RCutFlowReport.hxx:56:48: error: expected ‘)’ before ‘cutName’
  • [2022-08-09T12:14:58.315Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDF/RCutFlowReport.hxx:57:20: error: expected ‘;’ at end of member declaration
  • [2022-08-09T12:14:58.316Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDF/RCutFlowReport.hxx:57:40: error: expected ‘)’ before ‘cutName’
  • [2022-08-09T12:14:58.316Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/src/RCutFlowReport.cxx:33:68: error: no ‘const ROOT::RDF::TCutInfo& ROOT::RDF::RCutFlowReport::operator’ member function declared in class ‘ROOT::RDF::RCutFlowReport’

Warnings:

  • [2022-08-09T12:14:58.316Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDF/RCutFlowReport.hxx:57:28: warning: non-static reference ‘const ROOT::RDF::TCutInfo& ROOT::RDF::RCutFlowReport::At’ in class without a constructor [-Wuninitialized]

phsft-bot avatar Aug 09 '22 12:08 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-08-09T12:18:48.729Z] FAILED: tree/dataframe/G__ROOTDataFrame.cxx lib/ROOTDataFrame.pcm
  • [2022-08-09T12:18:50.342Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RDF/RCutFlowReport.hxx:56:36: error: no type named 'string_view' in namespace 'std'
  • [2022-08-09T12:18:50.342Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RDF/RCutFlowReport.hxx:57:28: error: no type named 'string_view' in namespace 'std'

phsft-bot avatar Aug 09 '22 12:08 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\inc\ROOT/RDF/RCutFlowReport.hxx(56,36): error C2039: 'string_view': is not a member of 'std' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\inc\ROOT/RDF/RCutFlowReport.hxx(56,48): error C2061: syntax error: identifier 'string_view' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\inc\ROOT/RDF/RCutFlowReport.hxx(56,56): error C2805: binary 'operator [' has too few parameters [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\inc\ROOT/RDF/RCutFlowReport.hxx(57,28): error C2039: 'string_view': is not a member of 'std' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\inc\ROOT/RDF/RCutFlowReport.hxx(57,40): error C2061: syntax error: identifier 'string_view' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\inc\ROOT/RDF/RCutFlowReport.hxx(57,69): error C2065: 'cutName': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\inc\ROOT/RDF/RCutFlowReport.hxx(57,58): error C2065: '[]': undeclared identifier [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\src\RCutFlowReport.cxx(34,1): error C2511: 'const ROOT::RDF::TCutInfo &ROOT::RDF::RCutFlowReport::operator ': overloaded member function not found in 'ROOT::RDF::RCutFlowReport' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\src\RCutFlowReport.cxx(39,15): error C2737: 'ciItEnd': const object must be initialized [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T13:02:25.057Z] C:\build\workspace\root-pullrequests-build\root\tree\dataframe\src\RCutFlowReport.cxx(40,59): error C3536: 'ciItEnd': cannot be used before it is initialized [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]

And 35 more

phsft-bot avatar Aug 09 '22 13:08 phsft-bot

Build failed on mac11/cxx14. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 09 '22 13:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 09 '22 16:08 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2022-08-09T17:20:17.286Z] C:\build\workspace\root-pullrequests-build\root\math\vecops\inc\ROOT/RVec.hxx(531,46): error C2039: 'VecOps': is not a member of 'ROOT::Detail::Internal' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T17:20:17.286Z] C:\build\workspace\root-pullrequests-build\root\math\vecops\inc\ROOT/RVec.hxx(531,46): error C3083: 'VecOps': the symbol to the left of a '::' must be a type [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T17:20:17.286Z] C:\build\workspace\root-pullrequests-build\root\math\vecops\inc\ROOT/RVec.hxx(531,54): error C2039: 'SmallVectorTemplateBase': is not a member of 'ROOT::Detail::Internal' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T17:20:17.286Z] C:\build\workspace\root-pullrequests-build\root\math\vecops\inc\ROOT/RVec.hxx(531,77): error C2059: syntax error: '<' [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]
  • [2022-08-09T17:20:17.286Z] C:\build\workspace\root-pullrequests-build\root\math\vecops\inc\ROOT/RVec.hxx(531,84): error C2512: 'ROOT::Internal::VecOps::SmallVectorTemplateBase<T,true>': no appropriate default constructor available [C:\build\workspace\root-pullrequests-build\build\tree\dataframe\ROOTDataFrame.vcxproj]

phsft-bot avatar Aug 09 '22 17:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 10 '22 05:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 10 '22 06:08 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 10 '22 07:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 11 '22 08:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 11 '22 08:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 11 '22 11:08 phsft-bot

@phsft-bot build

pcanal avatar Aug 16 '22 14:08 pcanal

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 16 '22 14:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 16 '22 20:08 phsft-bot