Philippe Canal
Philippe Canal
just turning minimal OFF also leads to a working build.
What is the purpose of calling `Clone` in this and/or the original example?
Maybe, maybe not :). The practical effect of this is ('as expected'). * Copy ALL the meta data of the TTree/TNTuple * Attach the copy of the current directory. This...
A tool (Coverity) was complaining that the values used in the switch statement did not belong to the enum. (See ac36d879629fd67cf6fc9e955923ec9f98a2361c). I am guessing to avoid this we might also...
> Is this enum type EProperty really only range from 0 - 63? No, it uses (sparsely) the full range of a 32 bis integer (by using it essentially as...
> I don't think casting will change anything here. You a right. I am guessing that Coverity noticed that some of the case value were EProperty and complained that some...
> "case value is not a constant expression". Humm ... either I don't understand the meaning or Clang is 'wrong' on this part. Both ``` EProperty(kIsPointer | kBIT_ISSTRING) and kIsPointer...
> The range checks of that new warning are also known bad for some cases, not sure if that is one of them... In this case it ended being relevant...
> I don't care what Coverity thinks or complains about. I'm arguing that having integer constants is more correct than what we do right now Fair enough. Can you update...
> which I find much worse to read... I agree ... let's keep the code formatted as is.