root icon indicating copy to clipboard operation
root copied to clipboard

Remove more unused variables in various areas

Open hahnjo opened this issue 3 years ago • 3 comments

First delete nop method TMVA::SVWorkingSet::PrintStat(), then remove many more unused variables in various areas.

Note: If you absolutely require your part of this PR be split out, we can discuss but it's going to be work that I'd like to avoid if possible.

hahnjo avatar Aug 09 '22 12:08 hahnjo

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 09 '22 12:08 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 09 '22 12:08 phsft-bot

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 09 '22 13:08 phsft-bot

@lmoneta @pcanal this PR for the math/ / tmva/ parts as well as io/

hahnjo avatar Aug 15 '22 15:08 hahnjo

@hahnjo which of the variable in core/io were you concerned about?

pcanal avatar Aug 15 '22 17:08 pcanal

@hahnjo which of the variable in core/io were you concerned about?

The ones you commented on, at least these instances felt odd...

hahnjo avatar Aug 16 '22 08:08 hahnjo

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 16 '22 09:08 phsft-bot