Phillip
Phillip
We never had a diffsims logo. My suggestions would be: 1) simplify a lot, it needs to vaguely make sense when very small on a big screen 2) I wouldn't...
I really like this @CSSFrancis
This would obviously be an improvement to the API, but unless somebody needs it urgently I think we should deprioritise it (at least until #201 and it's support PR are...
Just be careful with the plotting, I would be inclined to use the properties of the simulations (specifically the indexes of the vectors to check) - for example I think...
Both, been thinking about sweeping this up for the next release. It looks like it's two things: 1) `get_rotation_to_z_direction ` should be rewritten into orix syntax. 2) `calculate_ed_data` needs to...
I agree broadly with what has been said so far. My only comments would be 1) I think diffsims is the right place for code that converts 'simulations' (ie. coordinates...
Atom packages are nuisance. We started using `pymatgen` and had to drop it in favour of `diffpy`. I would be cautious about rewriting too much as could quickly spiral into...
> From my perspective I think this goes back to the question of: Do we want to support cbed pattern simulations/4-D STEM vs are we just focused on spot patterns?...
Hi, I'm going to move this issue over to diffsims (as it's a simulation, that's handled by them). It's not obvious to me what is wrong at a glance, but...
I think MULTEM is currently getting a python wrapper which may be a good option too.