Results 175 comments of Phillip

~When I get to this I'll try and pick up #840, #841 and #856 as well.~ UPD: Dealt with in #873, this issue is now specifically about the `.apply_affine_transform` failure

~and I think I'll make a release so that #868 can come into main as soon as possible~ UPD: Not making a patch release, changes are too small.

There isn't a really a short answer to these questions, but the last time Dieter and I spoke the conclusion we reached was that there are a lot of unexploited...

> @pc494 > > > but similarly, there is little enthusiasm from either us or LiberTEM to "merge" the two packages into one > > As far as I understood,...

It's also (as it happens) a special case of `Diffraction2D.apply_affine_transformation()`. Shall we use this thread as a place to keep track of such duplications?

I've been thinking about what we're likely to want in 0.14 recently, and I think this high (near top) on that agenda. Can I get back to you on specifics?

`CrystalMap.is_in_data` is pleasing unambiguous... I checked LIBERTEM, they use `1` to mean "included in data" too.

I think we should copy+paste the 0.18 implementation into pyxem as a short term solution. @CSSFrancis do you think that makes sense?

I think some generators (generally those that take two complicated pyxem classes) are an asset to the code. That said I think we've been a bit generous with what we...

You're doing a good portion of the development at the moment, so I'm not at all worried about timings.